feat(dips): enhance logging with agreement ID in DIPs processing #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
force-pushed
the
lnsd/feat-dips-enhace-logging
branch
from
578b7d4 to
fd26447
Compare
Pull Request Test Coverage Report for Build 14193290813Details
💛 - Coveralls |
Signed-off-by: Lorenzo Delgado <[email protected]>
LNSD
force-pushed
the
lnsd/feat-dips-enhace-logging
branch
from
fd26447 to
416802d
Compare
pcarranzav
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve logging and error handling in the
validate_and_create_agreementfunction and adds detailed tracing in theget_escrow_accounts_v1function. The most significant changes include adding the agreement ID to debug logs, enhancing error logs, and adding a trace log for escrow accounts response.crates/dips/src/lib.rs: Added agreement ID to debug logs for better traceability when validating and creating agreements. [1] [2]crates/dips/src/lib.rs: Enhanced error logs to include the agreement ID and other relevant metadata when creating agreements fails.crates/dips/src/lib.rs: Extracted and parsed the agreement ID from the voucher for logging purposes.crates/monitor/src/escrow_accounts.rs: Added a trace log to capture the response of escrow accounts for better debugging.